Update runtime-debug error handling #2737
Conversation
MDrakos
commented
Aug 25, 2023
•
MDrakos
commented
 DX-2124 Categorize runtime-debug errors
|
| if e.Err != nil { | ||
| return e.Err.Error() | ||
| } |
There was a problem hiding this comment.
I'm guessing prior to this change we weren't surfacing this error? Any idea what type of errors this is fixing?
There was a problem hiding this comment.
This change also introduces the Err field: https://github.com/ActiveState/cli/pull/2737/files#diff-14612946db10f18744a68890b9e353cf87d4da9104592d9fe4346264ed83ef77R95
There was a problem hiding this comment.
I get that, but that doesn't do anything to let us identify the error type, which is what this story is about. I'm not against also including this change, I just want to understand what this change does? What type of scenario are we not handling prior to this change?
There was a problem hiding this comment.
We are already identifying build planner errors but this has only been solving errors. Adding the error field and returning it first allows us to also capture other errors that we want to be considered as build planner errors. In this PR I've included deprecation and fallback errors when processing a build planner response to this type so they will also be identified as build planner errors.
