Added analytics dimension for state tool use on state tool CI. #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Aug 24, 2023
•
mitchell-as
commented
 DX-2118 As a DWH engineer I can easily filter out traffic coming from ActiveState automations
|
mitchell-as
force-pushed
the
mitchell/dx-2118
branch
5 times, most recently
from
741cc4c
to
b9660bf
Compare
mitchell-as
force-pushed
the
mitchell/dx-2118
branch
from
b9660bf
to
a5aa0b9
Compare
Naatan
approved these changes
Aug 24, 2023
| @@ -601,6 +601,8 @@ func (suite *AnalyticsIntegrationTestSuite) TestCIAndInteractiveDimensions() { | |||
| } | |||
| suite.Equal(condition.OnCI(), *e.Dimensions.CI, "analytics should report being on CI") | |||
| suite.Equal(interactive, *e.Dimensions.Interactive, "analytics did not report the correct interactive value for %v", e) | |||
| suite.Equal(condition.OnCI(), // not InActiveStateCI() because if it's false, we forgot to set ACTIVESTATE_CI env var in GitHub Actions scripts | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.