Don't retry DNS errors #2728
Closed
Don't retry DNS errors #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MDrakos
commented
Aug 23, 2023
•
MDrakos
commented
 DX-2146 `State shell` hangs forever with no internet
|
Naatan
reviewed
Aug 23, 2023
Naatan
requested changes
Aug 28, 2023
There was a problem hiding this comment.
We can't address the issue with this type of fix as we do in fact want to retry DNS errors. On Windows particularly that would fix a lot of issues.
What we want it to do is fail early if it has no chance of succeeding.. but I'm gathering that may not be possible?
|
https://stackoverflow.com/questions/76296690/http-client-faster-timeout-when-no-network It doesn't seem like there are any good solutions to this problem. Let's bring the ticket back to triage so we can discuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.