Delete a remotely created project if runtime setup fails. #2725
Conversation
mitchell-as
commented
Aug 22, 2023
•
mitchell-as
commented
 DX-2093 init project with `--language [email protected]` cause actual creation of the project in the platform
|
|
@daved ping |
|
@Naatan Should the deletion occur when there is any error after platform project creation? |
| logging.Debug("Deleting remotely created project due to runtime setup error") | ||
| err2 := model.DeleteProject(namespace.Owner, namespace.Project, r.auth) | ||
| if err2 != nil { | ||
| multilog.Error("Error deleting remotely created project after runtime setup error: %v", errs.JoinMessage(err2)) |
There was a problem hiding this comment.
This should be returned to the user. It means they're in a broken state and they should be made aware of it.
The AC says "when the runtime fails to source"; so no not any error, just runtime errors. Seems the code as is addressed the AC, although it should still communicate failure of deletion to the user. |
mitchell-as
force-pushed
the
mitchell/dx-2093
branch
from
6a4932a
to
1f2f3d7
Compare
|
@Naatan The reason I asked is because I thought the underlying purpose was to ensure that the remote and local states were effectively equal. Deleting only during runtime handling seems to leave a window open for the disparity to occur. |
|
@daved What other conditions do you think we should consider? The ACs are pretty clear. I'm not against expanding the scope if we find other cases, but this discussion feels very open-ended at the moment. Are you seeing a particular issue, or are you just putting out feelers? |
|
@Naatan The errors that can happen after a project is first created on the platform are from:
This PR will remove the created project from the platform for the last behavior only, but there are two steps prior that could leave the user in an undesirable workflow. |
|
I see.. I don't think it's worth expanding the check to those necessarily. While those are API's that can of course give an error, the error condition would only happen in unexpected scenario's, in which case I'd rather not go deleting projects. For the runtime scenario, we know what this error scenario means, so acting on it with intend is perfectly reasonable. |
