Support user-facing BuildPlanner errors #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naatan
requested changes
Aug 22, 2023
|
|
||
| func ProcessCommitError(commit *Commit, fallbackMessage string) error { | ||
| if commit.Error == nil { | ||
| return errs.New(fallbackMessage) |
There was a problem hiding this comment.
Is this a scenario that we expect to happen? We might want to present something localized if that's the case.
There was a problem hiding this comment.
No, if this happens we've encountered an error type but the message wasn't set which would be an invalid according to the build planner's schema.
| } | ||
|
|
||
| return b.Commit.CommitID, nil | ||
| return errs.New(fallbackMessage) |
There was a problem hiding this comment.
We don't want to silence this one (input error)?
There was a problem hiding this comment.
In this case, if we have to use the fallback message we've encountered an error type that we aren't handling so we should update these functions.
Co-authored-by: Nathan Rijksen <[email protected]>
Naatan
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on this PR, a better way to handle the various error types coming from the BuildPlanner surfaced. This PR updates our error handling in this regard.