Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added team notice when renaming or moving a project. #2718

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Aug 21, 2023

StoryDX-1971 Provide details on potentially disruptive nature of renaming or changing owner of project

@mitchell-as mitchell-as requested a review from daved August 22, 2023 14:39
@mitchell-as mitchell-as marked this pull request as ready for review August 22, 2023 14:39
internal/runners/projects/move.go Outdated Show resolved Hide resolved
internal/runners/projects/edit.go Outdated Show resolved Hide resolved
@mitchell-as mitchell-as requested a review from daved August 22, 2023 17:16
params.Namespace.String(),
params.NewOwner,
params.Namespace.Project), &defaultChoice)
move, err := m.prompt.Confirm("", locale.Tr("move_prompt", params.Namespace.String(), params.NewOwner, params.Namespace.Project), &defaultChoice)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, just noting my personal (and the community's) preference for vertical formatting versus horizontal. In these cases, I tend to start formatting in a way that looks like a struct.

@mitchell-as mitchell-as merged commit 59bbb9c into version/0-41-0-RC1 Aug 22, 2023
@mitchell-as mitchell-as deleted the mitchell/dx-1971 branch August 22, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants