Skip to content

Commit

Permalink
Go back to ignoring '-v' for installer.
Browse files Browse the repository at this point in the history
install.sh and install.ps1 will forward that flag, and it should not be interpreted as --version.
  • Loading branch information
mitchell-as committed Dec 13, 2023
1 parent d64ab90 commit 8d53c61
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions cmd/state-installer/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -186,15 +186,14 @@ func main() {
Value: &params.path,
},
{
Name: "version",
Shorthand: "v",
Value: &params.showVersion,
Name: "version", // note: no shorthand because install.sh uses -v for selecting version
Value: &params.showVersion,
},
// The remaining flags are for backwards compatibility (ie. we don't want to error out when they're provided)
{Name: "nnn", Shorthand: "n", Hidden: true, Value: &garbageBool}, // don't prompt; useless cause we don't prompt anyway
{Name: "channel", Hidden: true, Value: &garbageString},
{Name: "bbb", Shorthand: "b", Hidden: true, Value: &garbageString},
{Name: "vvv", Hidden: true, Value: &garbageString},
{Name: "vvv", Shorthand: "v", Hidden: true, Value: &garbageString},
{Name: "source-path", Hidden: true, Value: &garbageString},
},
[]*captain.Argument{
Expand Down

0 comments on commit 8d53c61

Please sign in to comment.