Output deprecation notice from main instead of projectfile package.

cmd/state/main.go

@@ -162,8 +162,6 @@ func run(args []string, isInteractive bool, cfg *config.Instance, out output.Out
 		return logData
 	})
 
-	projectfile.RegisterOutputer(out) // note: this needs to be done before using auth
-
 	auth := authentication.New(cfg)
 	defer events.Close("auth", auth.Close)
 
@@ -174,6 +172,9 @@ func run(args []string, isInteractive bool, cfg *config.Instance, out output.Out
 	projectfile.RegisterMigrator(migrator.NewMigrator(auth, cfg))
 
 	// Retrieve project file
+	if os.Getenv("ACTIVESTATE_PROJECT") != "" {
+		out.Notice(locale.T("warning_activestate_project_env_var"))
+	}
 	pjPath, err := projectfile.GetProjectFilePath()
 	if err != nil && errs.Matches(err, &projectfile.ErrorNoProjectFromEnv{}) {
 		// Fail if we are meant to inherit the projectfile from the environment, but the file doesn't exist

pkg/projectfile/projectfile.go

@@ -25,7 +25,6 @@ import (
 	"github.com/ActiveState/cli/internal/logging"
 	"github.com/ActiveState/cli/internal/multilog"
 	"github.com/ActiveState/cli/internal/osutils"
-	"github.com/ActiveState/cli/internal/output"
 	"github.com/ActiveState/cli/internal/profile"
 	"github.com/ActiveState/cli/internal/rollbar"
 	"github.com/ActiveState/cli/internal/rtutils"
@@ -66,14 +65,6 @@ func RegisterMigrator(m MigratorFunc) {
 	migrator = m
 }
 
-var out output.Outputer
-
-// RegisterOutputer registers the outputer this package uses for outputing things like deprecation
-// warnings.
-func RegisterOutputer(o output.Outputer) {
-	out = o
-}
-
 type ErrorParseProject struct{ *locale.LocalizedError }
 
 type ErrorNoProject struct{ *locale.LocalizedError }
@@ -821,16 +812,9 @@ func GetProjectFilePath() (string, error) {
 	return "", &ErrorNoProject{locale.NewInputError("err_no_projectfile")}
 }
 
-var printedActiveStateProjectDeprecationNotice = false
-
 func getProjectFilePathFromEnv() (string, error) {
 	var projectFilePath string
 
-	if legacy := os.Getenv("ACTIVESTATE_PROJECT"); legacy != "" && !printedActiveStateProjectDeprecationNotice {
-		out.Notice(locale.T("warning_activestate_project_env_var"))
-		printedActiveStateProjectDeprecationNotice = true
-	}
-
 	if activatedProjectDirPath := os.Getenv(constants.ActivatedStateEnvVarName); activatedProjectDirPath != "" {
 		projectFilePath = filepath.Join(activatedProjectDirPath, constants.ConfigFileName)
 	}