Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tests and documentation, also some fixes #97

Closed
wants to merge 15 commits into from
Closed

New tests and documentation, also some fixes #97

wants to merge 15 commits into from

Conversation

Kriskras99
Copy link

I know this is a big PR and sorry for that, but it brings some useful changes.

Changes:

  • Allow usage of appauthor on OS X (issue Why user_data_dir in Mac OS X does not include appauthor? #80)
  • Use environment variables and KNOWNFOLDERID instead of CSIDL (may break XP support)
  • Accept int and float in the version parameter
  • Changed documentation style to numpydoc and improved it
  • New test suite seperated by operating system, designed for travis-ci.org and appveyor.com
  • Bumped version number to 1.5.0 because of changed usage of appauthor

@Kriskras99
Update OS X url
d4a16bc 
The old one returns a 404, the new one should be exactly the same page.

Signed-off-by: Christiaan Biesterbosch <[email protected]>
@Kriskras99
If version was an int or float, appdirs would fail.
daa51b3 
os.path.join() does not accept ints or floats so use str().
Also fixed wrong indentation and replaced `not False` with `True`.
@Kriskras99
Use KNOWNFOLDERID instead of CSIDL
ea92dce 
It first tries the environment variable, if it does not exist use
KNOWNFOLDERID.
@Kriskras99
Moved Dev Notes to docstring
3ea3bf6
@Kriskras99
Allow usage of appauthor on OS X
d87021e 
Also reworks some of the if-else constructions.
@Kriskras99
Overhaul of documentation
c30c7fb 
The docstrings now follow the numpydoc style and describe what
the directories should be used for.
@Kriskras99
Updated .gitignore
101be34
@Kriskras99
New testsuite
8ad01ab 
Use travis-ci to test on OS X and Linux, and use AppVeyor to
test on Windows.
@Kriskras99
Fixed tests
fa1c074 
AppVeyor and Python 2.6 don't play nicely.
OS X and Python and Travis also don't play nicely.
Also fixed a small mistake I made in site_data_dir
@Kriskras99
Use Win7 instead of WinXP in readme, also typos
0720001
@Kriskras99
Remove selftest code in favor of unittests
001d0f4
@Kriskras99
Update version number and changelog
86a5953
@Kriskras99
Dont test Python3.2 on travis and do test pypy3
228b29a
@Kriskras99
Copy link
Author

Kriskras99 commented Jul 17, 2017 •
edited
Loading

Travis is going a bit crazy :(
It's still testing Python3.2 and not PyPy3, weird.
The test does work in my repository: https://travis-ci.org/Kriskras99/appdirs/builds/254493144

@zoofood
Copy link
Contributor

zoofood commented Jul 21, 2017

Thanks for the large PR Kriskras99! I will have to set aside some time to review, but at first glance it looks promising.

@Kriskras99
Copy link
Author

Take your time, I'm going on vacation so spotty wifi at best

@Kriskras99
Copy link
Author

@zoofood Did you have the chance to review this yet?

@McSinyx McSinyx mentioned this pull request Apr 13, 2018
Closed
@Kriskras99 Kriskras99 closed this Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kriskras99 @zoofood