Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-1743. update Postmark Ruby gem to support CustomTracking #156

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

J0SUEFDZ
Copy link

JIRA

What

  • Adds support for CustomTracking in the postmark gem.
  • Since the gem directly communicates with the API, all responses already include the changes to support CustomTrackingCNAMEValue, CustomTrackingDomain, and CustomTrackingVerified values where required, so no extra work is needed.
  • This PR enables the possibility to verify the domain using verify_domain_custom_tracking

Why

With CustomTracking almost ready to ship to production, we needed to add support for CustomTracking in this gem.

Tests

Manual tests for all endpoints pertinent to Custom Tracking, specified in the JIRA ticket, are returning the expected outut.

@J0SUEFDZ
Copy link
Author

FYI Tried to ask for approval from the postmark-ruby team but it doesn't appear on the list, so I asked for a review individually

Copy link
Contributor

@tomek-ac tomek-ac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @J0SUEFDZ could you please remove the version and changelog updates from this PR? We typically update the version in a separate task.

@J0SUEFDZ J0SUEFDZ self-assigned this Jul 30, 2024
@J0SUEFDZ J0SUEFDZ requested a review from tomek-ac July 30, 2024 21:48
Copy link
Contributor

@tomek-ac tomek-ac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove that change to lib/postmark/client.rb from this PR but other than that it looks good to me 👍

lib/postmark/client.rb Outdated Show resolved Hide resolved
@J0SUEFDZ
Copy link
Author

Thanks @tomek-ac. From my understanding, I can merge this without releasing, but I'll wait until the API is released to merge and release this. I'll follow the RELEASE.md instructions when I do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants