Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwiftUI improvements #149

Merged
merged 10 commits into from
May 28, 2024
Merged

SwiftUI improvements #149

merged 10 commits into from
May 28, 2024

Conversation

olejnjak
Copy link
Member

  • make lineHeight parameter optional for FontModifier
  • implement color forwarding from UIKit to SwiftUI
  • add ACKHostingController

@olejnjak olejnjak self-assigned this May 27, 2024
@olejnjak olejnjak enabled auto-merge (squash) May 27, 2024 14:56
@olejnjak olejnjak force-pushed the optional-line-height branch from 6db9c50 to 1dbb97a Compare May 27, 2024 15:21
@olejnjak olejnjak force-pushed the optional-line-height branch from 20b92a1 to 61b3b04 Compare May 27, 2024 18:47
IgorRosocha
IgorRosocha approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@IgorRosocha IgorRosocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job! 🙌

@olejnjak olejnjak merged commit 1465515 into main May 28, 2024
6 checks passed
@olejnjak olejnjak deleted the optional-line-height branch May 28, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorRosocha IgorRosocha IgorRosocha approved these changes

@LukasHromadnik LukasHromadnik Awaiting requested review from LukasHromadnik

Assignees

@olejnjak olejnjak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olejnjak @IgorRosocha