Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template merge #143

Merged
merged 12 commits into from
Feb 7, 2024
Merged

Template merge #143

merged 12 commits into from
Feb 7, 2024

Conversation

olejnjak
Copy link
Member

@olejnjak olejnjak commented Dec 28, 2023

Merge code from our template so we do not have to maintain two libraries.

Removed deploy workflow as now it is not that simple to implement and once we would add a module, we would probably forget to add it so I think it is better to omit that.

Checklist

  • Added tests (if applicable)

@olejnjak olejnjak self-assigned this Dec 28, 2023
@olejnjak olejnjak marked this pull request as ready for review January 28, 2024 18:26
@olejnjak olejnjak enabled auto-merge (squash) January 28, 2024 18:27
Copy link
Contributor

@IgorRosocha IgorRosocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job! 💪

let subject = OAuthInterceptor(
isExpiredAuthDataResponse: { response in
let request = response.request
print("[IS_EXPIRED]", request.allHTTPHeaderFields!["index"]!, request.allHTTPHeaderFields!["refreshed"] ?? "false")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Do we want to keep these test prints?

@olejnjak olejnjak merged commit 63f633a into main Feb 7, 2024
4 checks passed
@olejnjak olejnjak deleted the template_merge branch February 7, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants