Uicolor hexcolor init #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 2, 2023 11:19
|
@freed0m266 your pull request is missing a changelog! |
olejnjak
requested changes
Nov 2, 2023
| } | ||
| convenience init(hexString: String) { | ||
| var hexSanitized = hexString.trimmingCharacters(in: .whitespacesAndNewlines) | ||
| hexSanitized = hexSanitized.replacingOccurrences(of: "#", with: "") |
There was a problem hiding this comment.
To achieve this kind of change you can simply use the original 5 line solution and only adjust scanLocation based on whether the string has leading hash or not.
babacros
reviewed
Nov 3, 2023
Comment on lines
+27
to
+48
| var rgb: UInt64 = 0 | ||
|
|
||
| var r: CGFloat = 0.0 | ||
| var g: CGFloat = 0.0 | ||
| var b: CGFloat = 0.0 | ||
| let a: CGFloat = 1.0 | ||
|
|
||
| let length = hexSanitized.count | ||
|
|
||
| guard Scanner(string: hexSanitized).scanHexInt64(&rgb) else { | ||
| self.init() | ||
| return | ||
| } | ||
|
|
||
| if length == 6 { | ||
| r = CGFloat((rgb & 0xFF0000) >> 16) / 255.0 | ||
| g = CGFloat((rgb & 0x00FF00) >> 8) / 255.0 | ||
| b = CGFloat(rgb & 0x0000FF) / 255.0 | ||
| } else { | ||
| self.init() | ||
| } | ||
|
|
There was a problem hiding this comment.
👋 Hey, I agree with @olejnjak. By the way, comments are missing...and what about correct indentation? Is it just copy&paste from Stack Overflow? In the case of using ChatGPT, I would ask to add comments 🤔
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist