Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/1836 Ensure automatic new version creation only happens to multi-step jourmeys without a draft version #1930

Merged
merged 2 commits into from
Dec 13, 2024
Merged

bug/1836 Ensure automatic new version creation only happens to multi-step jourmeys without a draft version #1930

merged 2 commits into from
Dec 13, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Dec 13, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 7.6.0 milestone Dec 13, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Coverage Report

Commit:75d5e66
Base: develop@2e3ebe7

Type Base This PR
Total Statements Coverage  69.09%  69.08%  (-0.01%)
Total Branches Coverage  68.97%  68.94%  (-0.03%)
Total Functions Coverage  81.63%  81.63%  (+0%)
Total Lines Coverage  69.09%  69.08%  (-0.01%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Journey.js  52.85%  59.44%  69.56%  52.85%

@JoernBerkefeld JoernBerkefeld linked an issue Dec 13, 2024 that may be closed by this pull request
[BUG] transactional send journeys cannot be versioned or updated if active/published #1836
Closed
2 tasks
@JoernBerkefeld JoernBerkefeld self-assigned this Dec 13, 2024
@JoernBerkefeld JoernBerkefeld merged commit 9e9ddd8 into develop Dec 13, 2024
9 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1836-transactional-send-journeys-cannot-be-versioned-or-updated-if-activepublished branch December 13, 2024 16:42
@github-actions github-actions bot mentioned this pull request Dec 13, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/journey COMPONENT c/transactionalEmail
Projects
None yet
Milestone
7.6.0
Development

Successfully merging this pull request may close these issues.

[BUG] transactional send journeys cannot be versioned or updated if active/published
1 participant
@JoernBerkefeld