Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/1730 resolve deliveryprofile in journeys #1731

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Task/1730 resolve deliveryprofile in journeys #1731

merged 5 commits into from
Sep 24, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Sep 23, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 7.4.3 milestone Sep 23, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 23, 2024
@github-actions github-actions bot added the chore Jira issue-type "Task" label Sep 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Coverage Report

Commit:4ded753
Base: develop@1a2a899

Type Base This PR
Total Statements Coverage  69.82%  69.79%  (-0.03%)
Total Branches Coverage  68.68%  68.7%  (+0.02%)
Total Functions Coverage  81.57%  81.6%  (+0.03%)
Total Lines Coverage  69.82%  69.79%  (-0.03%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Journey.js  58.92%  60.09%  75%  58.92%
lib/metadataTypes/SendClassification.js  91.62%  81.25%  100%  91.62%

@JoernBerkefeld JoernBerkefeld linked an issue Sep 24, 2024 that may be closed by this pull request
[TASK] resolve deliveryProfile in journeys #1730
Closed
@JoernBerkefeld JoernBerkefeld merged commit ae81246 into develop Sep 24, 2024
11 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/1730-resolve-deliveryprofile-in-journeys branch September 24, 2024 07:31
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/deliveryProfile COMPONENT c/journey COMPONENT chore Jira issue-type "Task"
Projects
None yet
Milestone
7.4.3
Development

Successfully merging this pull request may close these issues.

[TASK] resolve deliveryProfile in journeys
1 participant
@JoernBerkefeld