Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/1674 ensure journey activities and entry-event fields are sorted to ease pull request reviews #1700

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Task/1674 ensure journey activities and entry-event fields are sorted to ease pull request reviews #1700

merged 5 commits into from
Sep 12, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Sep 12, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added c/event COMPONENT c/journey COMPONENT labels Sep 12, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.4.1 milestone Sep 12, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 12, 2024
@github-actions github-actions bot added the chore Jira issue-type "Task" label Sep 12, 2024
@JoernBerkefeld JoernBerkefeld changed the title Task/1674 ensure journey activities are always sorted the same way to make git comparison easier Task/1674 ensure journey activities and entry-event fields are sorted to ease pull request reviews Sep 12, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Sep 12, 2024 that may be closed by this pull request
[TASK] ensure journey activities are always sorted the same way to make git comparison easier #1674
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

Coverage Report

Commit:607c31c
Base: develop@f2176b1

Type Base This PR
Total Statements Coverage  69.82%  69.82%  (+0%)
Total Branches Coverage  68.65%  68.68%  (+0.03%)
Total Functions Coverage  81.55%  81.57%  (+0.02%)
Total Lines Coverage  69.82%  69.82%  (+0%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit 6e79ccb into develop Sep 12, 2024
11 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/1674-ensure-journey-activities-are-always-sorted-the-same-way-to-make-git-comparison-easier branch September 12, 2024 12:40
@github-actions github-actions bot mentioned this pull request Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/event COMPONENT c/journey COMPONENT chore Jira issue-type "Task"
Projects
None yet
Milestone
7.4.1
Development

Successfully merging this pull request may close these issues.

[TASK] ensure journey activities are always sorted the same way to make git comparison easier
1 participant
@JoernBerkefeld