#139: fix bugs during execution of document accountUser

Accenture · Feb 24, 2023 · e945676 · e945676
1 parent a4589bc
commit e945676
Showing 1 changed file with 22 additions and 17 deletions.
diff --git a/lib/metadataTypes/AccountUser.js b/lib/metadataTypes/AccountUser.js
@@ -593,12 +593,33 @@ class AccountUser extends MetadataType {
             );
             return;
         }
-        if (Object.keys(metadata).length === 1) {
+
+        // if ran as part of retrieve/deploy with key, exit here
+        if (metadata && Object.keys(metadata).length === 1) {
             Util.logger.debug(
                 'Only 1 user found. Skipping documentation, assuming we ran retrieve-by-key.'
             );
             return;
         }
+
+        if (!metadata) {
+            // load users from disk if document was called directly and not part of a retrieve
+            try {
+                metadata = this.readBUMetadataForType(
+                    File.normalizePath([
+                        this.properties.directories.retrieve,
+                        this.buObject.credential,
+                        Util.parentBuName,
+                    ]),
+                    true
+                ).accountUser;
+            } catch (ex) {
+                Util.logger.error(ex.message);
+                return;
+            }
+        }
+
+        // print summary to cli
         const counter = {
             userActive: 0,
             userInactive: 0,
@@ -620,22 +641,6 @@ class AccountUser extends MetadataType {
             )
         );
 
-        if (!metadata) {
-            // load users from disk if document was called directly and not part of a retrieve
-            try {
-                metadata = this.readBUMetadataForType(
-                    File.normalizePath([
-                        this.properties.directories.retrieve,
-                        this.buObject.credential,
-                        Util.parentBuName,
-                    ]),
-                    true
-                ).accountUser;
-            } catch (ex) {
-                Util.logger.error(ex.message);
-                return;
-            }
-        }
         // init map of BU Ids > BU Name
         this._getBuNames();