added a python script to validate the sonar token before it is generated

[RobeDevOps]

• Added new python script to validate the sonar token generation
• If token exists then the process of generation is skipped.

This issue is fixed based on
Accenture/adop-docker-compose#285

[RobeDevOps]

Please let me know who can be the reviewer and if anything needs to be fixed or improved.

[dsingh07]

Hi @RobeDevOps Thank you for the PR! Looks good to me!

Just wondering if it's possible to extend the existing bash script to deal with the case where a token already exists rather than needing an extra python script to do the checking? I think it will make it easier to debug and decipher if all the logic for the sonar auth token generation is encapsulated within one script. What do you think?

/CC @RobertNorthard

[RobeDevOps]

I am ok with you if you are ok installing jq in order to iterate the json array using bash script? Using jq should be easy to iterate the token list extending the same bash. Let me know and I will add jq to the tools and implement the solution into the script.

[dsingh07]

@RobeDevOps Yes I think, let's proceed with that approach, this will keep it cleaner and make it easier to debug, thanks!

[RobeDevOps]

@dsingh07 I removed the python script and added the python code as simple extension into the bash script file.

• If the list is empty return empty token so, token is gonna be generated
• Looping the token arrays and it returns the token ( if exists)
• Finally returns empty value if not token found.

Please let me know if that is ok. I think the python script is simple and adding jq to the Dockerfile is going to increase the image size and also a new tool and dependencies.

[dsingh07]

Thanks a lot @RobeDevOps that sounds good to me, I'll try and test it as soon as possible and hopefully merge :)

[RobertNorthard]

Thanks @RobeDevOps - I like the approach

[dsingh07]

Hi @RobeDevOps LGTM, I have tested this and this works as expected!

• Image builds fine from the PR
• ADOP/C instance stands up fine with this image tag used in the compose file
• Sonar integration in place as expected
• Brought down ADOP/C instance using ./adop compose down
• Brought it back up again using ./adop compose init
• ADOP/C stands up fine again and no errors in the Jenkins logs
• Sonar integration still in place

Happy to merge, do you think it would be possible to squash commits?

[RobeDevOps]

I squashed the commits in one. 👍

[dsingh07]

Thanks @RobeDevOps LGTM, merging!

[dsingh07]

@RobeDevOps New 0.3.5 release is created: https://hub.docker.com/r/accenture/adop-jenkins/builds/

Please can you create an accompanying to adop-docker-compose to update the image tag?