Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add release workflow and versioned docker builds #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChristophBe
Copy link
Member

No description provided.

@ChristophBe ChristophBe requested a review from jxhnx October 17, 2024 14:40
@ChristophBe ChristophBe force-pushed the ci/add-semantic-versioning branch 2 times, most recently from d2877aa to 66c5fbe Compare October 18, 2024 08:23
@ChristophBe ChristophBe force-pushed the ci/add-semantic-versioning branch from 66c5fbe to a754af9 Compare October 18, 2024 08:58
@jxhnx jxhnx self-assigned this Oct 21, 2024
- name: Determine Image Tag
if: ${{ github.ref_type == 'branch' }}
run: |
echo \"IMAGE_TAG=${{env.NEXT_RELEASE_VERSION}}-pre-release-$(git rev-parse --short ${{ github.sha }})\" >> $GITHUB_ENV
Copy link
Member

@jxhnx jxhnx Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will NEXT_RELEASE_VERSION be available? Since semantic release runs in a different job.

Comment on lines +11 to +13
push:
tags:
- '**'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this will ever trigger when we use another workflow to tag a commit. Last time I looked workflows could not trigger other workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants