-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap router #76
Merged
Merged
bootstrap router #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunjizhan
force-pushed
the
bootstrap-router
branch
from
October 22, 2024 12:28
22d95cb
to
41dd570
Compare
xlc
approved these changes
Oct 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 84.97% 82.25% -2.73%
==========================================
Files 27 28 +1
Lines 619 665 +46
Branches 69 77 +8
==========================================
+ Hits 526 547 +21
- Misses 91 96 +5
- Partials 2 22 +20
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Added endpoints for bootstrap router.
Bootstrap router is a little different than other routers that it won't destroy itself after routing for bootstrap, and it will only perform gas drop for the first route (AcalaNetwork/asset-router#62).
Tests
Added tests to make sure routing works as expected, especially that the behavior is different for the first and second route.
currently bootstrapping has not opened yet on mainnet, so in the test setup we need to manually do the necessary preparation and open it.