Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues with readthedocs, python 3.7, and broken clip test #1820

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

reinecke
Copy link
Collaborator

@reinecke reinecke commented Jan 13, 2025

Summarize your change.

A grab-bag of fixes for issues causing failing CI, including:

  1. Updated the CI to run linux python 3.7 checks on ubuntu 22.04 - the last version that includes python 3.7 in github runners- (see this version manifest for reference.
  2. Added an explicit path for the sphinx configuration in accordance with this blog post.
  3. Updated some clip unittests to account to effects and markers being included in the __str__ and __repr__ methods as of Add effect and marker initialization to Clip #1808

@github-actions github-actions bot added the ci label Jan 13, 2025
@reinecke reinecke force-pushed the fix/pin-python-37-old-ubuntu branch from 5bdbd87 to c51a83e Compare January 13, 2025 22:54
@reinecke reinecke changed the title Run python 3.7 on last supported ubuntu Fix CI issues with readthedocs and python 3.7 Jan 13, 2025
@reinecke reinecke force-pushed the fix/pin-python-37-old-ubuntu branch from 7f9c9ac to 580f443 Compare January 13, 2025 23:29
@reinecke reinecke changed the title Fix CI issues with readthedocs and python 3.7 Fix CI issues with readthedocs, python 3.7, and broken clip test Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant