Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 32-bit Python builds #1789

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

darbyjohnston
Copy link
Contributor

Fixes #1788

This PR disables x86 builds to help reduce CI time and troubleshooting.

Marking this as WIP to test the changes.

Signed-off-by: Darby Johnston <[email protected]>
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Aug 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.61%. Comparing base (c0e97b0) to head (2f3fb87).
Report is 22 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1789      +/-   ##
==========================================
- Coverage   84.11%   81.61%   -2.51%     
==========================================
  Files         198      176      -22     
  Lines       22241    12335    -9906     
  Branches     4687     3024    -1663     
==========================================
- Hits        18709    10067    -8642     
+ Misses       2610     1725     -885     
+ Partials      922      543     -379     
Flag Coverage Δ
py-unittests 81.61% <ø> (-2.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5184c36...2f3fb87. Read the comment docs.

@darbyjohnston
Copy link
Contributor Author

According to the documentation x86 is built by default on Windows and Linux:
https://cibuildwheel.pypa.io/en/stable/options/#archs

This change specifies to only build x86_64/AMD64.

@darbyjohnston darbyjohnston changed the title Disable x86 builds Disable 32-bit Python builds Aug 29, 2024
@darbyjohnston
Copy link
Contributor Author

Marking this as "ready for review" as discussed at the last TSC meeting.

So far there have been no responses to the OTIO slack post by @meshula that 32-bit builds are needed.

@darbyjohnston darbyjohnston marked this pull request as ready for review September 22, 2024 23:25
@jminor jminor merged commit 6d733fd into AcademySoftwareFoundation:main Sep 30, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable 32-bit Python builds
3 participants