Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find children broken #1653

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ggarra13
Copy link
Contributor

Link the Issue(s) this Pull Request is related to.

Each PR should link at least one issue, in the form:

This is a test for issue #1652. It does not fix it. It just adds a test for it.

Summarize your change.

Added a test_find_children.cpp that shows the problem.

Reference associated tests.

test_find_children.cpp.

Signed-off-by: Gonzalo Garramuño <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1653 (82c98c6) into main (eaf8569) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1653   +/-   ##
=======================================
  Coverage   79.91%   79.91%           
=======================================
  Files         197      197           
  Lines       21731    21731           
  Branches     4339     4339           
=======================================
+ Hits        17366    17367    +1     
  Misses       2213     2213           
+ Partials     2152     2151    -1     
Flag Coverage Δ
py-unittests 79.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf8569...82c98c6. Read the comment docs.

@meshula meshula added the bug A problem, flaw, or broken functionality. label Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem, flaw, or broken functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants