Chartkick 5.1.0 #13
Open
Chartkick 5.1.0 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elalemanyo
commented
Oct 8, 2024
•
elalemanyo
commented
- Update Chartkick
- Change branch to main
- Change ruby versions
- Replace webpack with esbuild
…d chartkick dependencies
…xpand Ruby version matrix
…oved performance and security
…-specific ffi entries
…est body and reduce Ruby version matrix
…ove CI skip condition
|
Thanks for taking care 👏 |
rstammer
reviewed
Oct 8, 2024
lib/iruby/chartkick/version.rb
Outdated
| @@ -1,6 +1,6 @@ | |||
| # frozen_string_literal: true | |||
| module IRuby | |||
| module Chartkick | |||
| VERSION = "0.3.1" | |||
| VERSION = "0.5.1" | |||
There was a problem hiding this comment.
Is there a reason to skip v0.4.0? Would be more logical to jump to this, wouldn't it?
There was a problem hiding this comment.
The idea was to leave it similar to the chartkick version 😅
There was a problem hiding this comment.
Thanks for pointing out 👍 I somehow disagree here, because I think keeping a coherent own version history makes more sense to avoid confusion - but - don't worry - I can live with that decision 😉 🫶
rstammer
approved these changes
Oct 9, 2024
lib/iruby/chartkick/version.rb
Outdated
| @@ -1,6 +1,6 @@ | |||
| # frozen_string_literal: true | |||
| module IRuby | |||
| module Chartkick | |||
| VERSION = "0.3.1" | |||
| VERSION = "0.5.1" | |||
There was a problem hiding this comment.
Thanks for pointing out 👍 I somehow disagree here, because I think keeping a coherent own version history makes more sense to avoid confusion - but - don't worry - I can live with that decision 😉 🫶
| @@ -1,14 +1,13 @@ | |||
| { | |||
| "name": "iruby-chartkick", | |||
| "scripts": { | |||
| "build": "webpack ./vendor/assets/javascripts/main.js --output-path='./vendor/assets/javascripts/' --output-filename=bundle.js --mode=production" | |||
| "build": "esbuild ./vendor/assets/javascripts/main.js --bundle --outfile=./vendor/assets/javascripts/bundle.js --minify" | |||
elalemanyo
commented
Oct 9, 2024
elalemanyo
commented
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.