#89 refactor project structure and sbt files #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
JaCoCo code coverage report - scala:2.12.17
|
Zejnilovic
reviewed
Jan 15, 2024
dk1844
reviewed
Jan 15, 2024
build.sbt
Outdated
| webappWebInfClasses := true, | ||
| inheritJarManifest := true, | ||
| // No need to publish the service | ||
| publish / skip := true, | ||
| javacOptions ++= Seq("-source", "1.8", "-target", "1.8", "-Xlint"), |
There was a problem hiding this comment.
How about saving these javacOptions to a (lazy) val and reusing it everywhere?
Zejnilovic
approved these changes
Jan 15, 2024
dk1844
deleted the
feature/89-refactor-project-structure-and-sbt-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a few changes that were mentioned by Sasa for sbt formatting and useage. Most Suggestions were minor and implemented in previous commits.
-This branch contains the larger change of refactoring the directory name (Not large in scope but changes may be difficult to review if it was baked into another branch)
Also minor change of removing parent module value and assigning those settings globally.
Closes #89