Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#80 application.conf is no longer baked into the docker image #88

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

dk1844
Copy link
Collaborator

@dk1844 dk1844 commented Jan 12, 2024

application.conf is no longer baked into the docker image, but loaded from /opt/config/application.yaml (not part of the image, needs to be mounted when run, e.g. via docker run -v)

certs copy limited to *.pem (only pems are used anyway)

…aded from /opt/config/application.yaml (not part of the image, needs to be mounted when run, e.g. via `docker run -v`)

certs copy limited to *.pem (only `pem`s are used anyway)
Copy link

JaCoCo code coverage report - scala:2.12.17

There is no coverage information present for the Files changed

Total Project Coverage 75.04% 🍏

@dk1844 dk1844 marked this pull request as ready for review January 16, 2024 13:36
Copy link
Collaborator

@TheLydonKing TheLydonKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read Code, LGTM

@dk1844 dk1844 merged commit 474aed7 into master Jan 17, 2024
3 checks passed
@dk1844 dk1844 deleted the feature/80-external-config branch January 17, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants