#5: Traits to support status_code reaction #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New exceptions for status code related failures * Documentation describing the standard status codes, how they have been agreed by the team * Mix-in trait for `DBFunction` for handling the status codes * `trait DBFunctionFabric` created to easy the creation of `DBFunction` mixing traits * `SlickPgFunction` refactored somewhat for easier `StatusHandling` trait integration
JaCoCo code coverage report - scala 2.11.12
|
JaCoCo code coverage report - scala 2.12.17
|
* Added UT
Zejnilovic
reviewed
May 29, 2023
.../src/test/scala/za/co/absa/fadb/statushandling/fadbstandard/StandardStatusHandlingTest.scala
Outdated
Show resolved
Hide resolved
|
This is not a goal of this PR, but I see that it is not following project name conventions. (Selected int the picture) |
.../src/test/scala/za/co/absa/fadb/statushandling/fadbstandard/StandardStatusHandlingTest.scala
Outdated
Show resolved
Hide resolved
examples/src/main/scala/za/co/absa/fadb/examples/enceladus/DatasetSchema.scala
Outdated
Show resolved
Hide resolved
…d/StandardStatusHandlingTest.scala Co-authored-by: miroslavpojer <[email protected]>
…asetSchema.scala Co-authored-by: miroslavpojer <[email protected]>
|
Yeah I noticed myself. I am in a middle of a bigger refactoring (which actually affects the class structure). And if I solve that - it's complicated - I will include the fix for |
core/src/main/scala/za/co/absa/fadb/statushandling/StatusHandling.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: miroslavpojer <[email protected]>
miroslavpojer
approved these changes
May 31, 2023
Technically this is not the refactoring but slowly enhancing the library (but refactoring is coming 😉 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBFunctionfor handling the status codestrait DBFunctionFabriccreated to easy the creation ofDBFunctionmixing traitsSlickPgFunctionrefactored somewhat for easierStatusHandlingtrait integrationThis can still be improved upon, but would be better after particularly #6, #7 and #8. (Some major refactoring might be still in order. But the status code traits will remain (mostly) how introduced here.)
Closes #5