Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination of auth zones and missing record view #21

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

jskrill
Copy link
Contributor

@jskrill jskrill commented Oct 1, 2024

This PR has two primary goals.

  1. Fetching AuthZones shares the same limitations that fetching records does with respect to # of results returned in a single request (_max_results must be set or infoblox wapi will error if # of results > 1000). Instead of unpredictably misbehaving when # Auth Zone results exceeds INFOBLOX_MAX_RESULTS or relying on huge _max_results, using pagination ensures that all the zones which match the query are fetched.
  2. When records are created, the record's view should match its parent zone (or more generally the INFOBLOX_VIEW config option). This fixes InfoBlox error: A parent was not found. #20 which is caused when a record is being created in a different view than its parent zone.

I also added some changes to Gitlab workflows to allow the creation of releases/images in forks. This should make it easier to for contributors to test their changes end-to-end.

@jskrill jskrill force-pushed the fix_missing_zone_and_pagination branch 3 times, most recently from ca5af1a to d2c0589 Compare October 3, 2024 21:31
@kuritka
Copy link
Collaborator

kuritka commented Nov 6, 2024

Hi @jskrill , can you rebase please?

@jskrill jskrill force-pushed the fix_missing_zone_and_pagination branch from d2c0589 to 4c68941 Compare November 9, 2024 01:50
@jskrill
Copy link
Contributor Author

jskrill commented Nov 9, 2024

Hi @kuritka, I rebased the PR.

@kuritka kuritka merged commit 241dcc9 into AbsaOSS:main Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InfoBlox error: A parent was not found.
3 participants