fix update cps-autocomplete component value #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korel-san
requested review from
fateeand,
TerranceKhumalo-absa and
lukasmatta
as code owners
korel-san
force-pushed
the
fix/update-cps-autocomplete-component-value
branch
from
3b474da
to
a15268c
Compare
TerranceKhumalo-absa
previously approved these changes
Oct 17, 2024
TerranceKhumalo-absa
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the following updates to the CpsAutocompleteComponent:
onBlur Method Update:
Modified the onBlur method to call _confirmInput instead of _closeAndClear when the component is not opened. This change ensures that input confirmation logic is executed instead of simply closing and clearing the input.
Value Reset Logic Enhancement:
Enhanced the logic for resetting the value in the component. Now, the value is only reset if the inputText has been changed by the user and does not match the current value label. This prevents unnecessary value resets and ensures that the component's state remains consistent with user input.
These changes improve the component's behavior by refining input handling and ensuring more accurate state management.