Update primeng version to 17.18.11 and align filter with update prime… #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerranceKhumalo-absa
requested review from
fateeand,
korel-san and
lukasmatta
as code owners
korel-san
reviewed
Oct 7, 2024
| (!isStrictMode && | ||
| (pTreeTable.isFilterMatched( | ||
| if ( | ||
| (isStrictMode && |
There was a problem hiding this comment.
@TerranceKhumalo-absa maybe we could create some variables for a better understanding of what exactly we are checking here
korel-san
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Global Filter Issue in Tree-Table
Resolves #405
Description
This pull request addresses the issue where the global filter for the tree-table component was not returning all relevant results.
Testing