Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

# 37 - Add debug logs calls into action response logic to provide use… #38

Merged
merged 2 commits into from
Nov 13, 2023
Merged

# 37 - Add debug logs calls into action response logic to provide use… #38

merged 2 commits into from
Nov 13, 2023

Conversation

miroslavpojer
Copy link
Collaborator

37 - Add debug logs calls into action response logic to provide useful debug information

  • Added debug message to validate and perform logic of ResponseAction.
  • Removed failing json part form test project before example.
  • Reworked main method to provide better testability.
  • Rework of related unit tests.

Closes #37

@miroslavpojer
# 37 - Add debug logs calls into action response logic to provide use…
ae25ba5 
…ful debug information

- Added debug message to validate and perform logic of ResponseAction.
- Removed failing json part form test project before example.
- Reworked main method to provide better testability.
- Rework of related unit tests.
@miroslavpojer miroslavpojer self-assigned this Nov 13, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited
Loading

JaCoCo code coverage report - ScAPI

File Coverage [85.93%] 🍏
StdOutReporter.scala 100% 🍏
ScAPIRunner.scala 94.92% 🍏
ExtractJsonResponseAction.scala 94.04% 🍏
AssertionResponseAction.scala 83.48% 🍏
LogResponseAction.scala 80.79% 🍏
Total Project Coverage 87.43% 🍏

@miroslavpojer miroslavpojer merged commit b98e1bb into master Nov 13, 2023
2 checks passed
@miroslavpojer miroslavpojer deleted the feature/37_Add_debug_logs_calls_into_action_response_logic_to_provide_useful_debug_information branch November 13, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zejnilovic Zejnilovic Zejnilovic approved these changes

@dk1844 dk1844 Awaiting requested review from dk1844

Assignees

@miroslavpojer miroslavpojer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add debug logs calls into action response logic to provide useful debug information
2 participants
@miroslavpojer @Zejnilovic