Feature/18 refactoring of response action to dynamic #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renamed assertion json tag to responseAction. * Refactored related logic and doc.
* Simplified json files for ResponseAction - ResponseActions group and name by method with meaning "group.name". In code this value is separated for more intuitive usage.
* Refactored responseActions logic to accept random parameter names. * Correct parameters are validated in time of project loading.
* Extended json schemas by descriptions and version.
JaCoCo code coverage report - ScAPI
|
…o_dynamic # Conflicts: # testApi/src/main/resources/schema/after.schema.json # testApi/src/main/resources/schema/before.schema.json # testApi/src/main/resources/schema/suite.schema.json # testApi/src/main/scala/africa/absa/testing/scapi/json/SuiteFactory.scala # testApi/src/main/scala/africa/absa/testing/scapi/rest/response/AssertionResponseAction.scala # testApi/src/main/scala/africa/absa/testing/scapi/rest/response/ExtractJsonResponseAction.scala # testApi/src/main/scala/africa/absa/testing/scapi/rest/response/LogResponseAction.scala # testApi/src/test/resources/project_with_issues/suites/aulgui-controller/undefinedConstantIssue.suite.json # testApi/src/test/resources/test_project/suites/gui-controller/deleteQuestion.suite.json # testApi/src/test/resources/test_project/suites/gui-controller/getUserCurrent.after.json # testApi/src/test/resources/test_project/suites/gui-controller/getUserCurrent.before.json # testApi/src/test/resources/test_project/suites/gui-controller/getUserCurrent.suite.json # testApi/src/test/resources/test_project/suites/gui-controller/postQuestion.suite.json # testApi/src/test/resources/test_project/suites/gui-controller/putQuestion.suite.json # testApi/src/test/scala/africa/absa/testing/scapi/rest/response/ResponseAssertionsTest.scala # testApi/src/test/scala/africa/absa/testing/scapi/rest/response/ResponseExtractTest.scala # testApi/src/test/scala/africa/absa/testing/scapi/rest/response/ResponseLogTest.scala # testApi/src/test/scala/africa/absa/testing/scapi/suite/runner/SuiteRunnerTest.scala
Zejnilovic
approved these changes
Aug 25, 2023
miroslavpojer
deleted the
feature/18-Refactoring_of_ResponseAction_to_dynamic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18 - Refactoring of ResponseAction to dynamic
Closes #18