Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#17 - Assertion rename and simplification #25

Merged
merged 3 commits into from
Aug 25, 2023
Merged

#17 - Assertion rename and simplification #25

merged 3 commits into from
Aug 25, 2023

Conversation

miroslavpojer
Copy link
Collaborator

@miroslavpojer miroslavpojer commented Aug 22, 2023 •
edited
Loading

  • Renamed assertion json tag to responseAction.
  • Refactored related logic and doc.
  • Simplified json files for ResponseAction.

Closes #17

@miroslavpojer
#17 - Assertion rename and simplification
ca67acc 
* Renamed assertion json tag to responseAction.
* Refactored related logic and doc.
@miroslavpojer miroslavpojer self-assigned this Aug 22, 2023
@miroslavpojer miroslavpojer removed the request for review from Zejnilovic August 22, 2023 06:23
@github-actions
Copy link

github-actions bot commented Aug 22, 2023 •
edited
Loading

JaCoCo code coverage report - ScAPI

File Coverage [92.54%] 🍏
Exceptions.scala 100% 🍏
Method.scala 100% 🍏
SuiteTestScenario.scala 100% 🍏
SuiteRunner.scala 97.8% 🍏
ReferenceResolver.scala 96.85% 🍏
AssertionResponseAction.scala 92.83% 🍏
LogResponseAction.scala 92.08% 🍏
ExtractJsonResponseAction.scala 91.71% 🍏
SuiteFactory.scala 85.6% 🍏
Response.scala 76.47% ❌
Total Project Coverage 84.04% 🍏

@miroslavpojer
Merge branch 'master' into feature/17_assertion_rename_and_simplifica…
b1e3ade 
…tion
@miroslavpojer
#17 - Assertion rename and simplification
9d89dc1 
* Simplified json files for ResponseAction - ResponseActions group and name by method with meaning "group.name". In code this value is separated for more intuitive usage.
@miroslavpojer miroslavpojer merged commit 6bb4b24 into master Aug 25, 2023
2 checks passed
@miroslavpojer miroslavpojer deleted the feature/17_assertion_rename_and_simplification branch August 25, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zejnilovic Zejnilovic Zejnilovic approved these changes

@benedeki benedeki Awaiting requested review from benedeki

Assignees

@miroslavpojer miroslavpojer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion rename and simplification
2 participants
@miroslavpojer @Zejnilovic