Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABRiS #343 Add support for Apache Spark 4.0.0-SNAPSHOT with fewer exceptions #358

Conversation

ni-mi
Copy link
Contributor

@ni-mi ni-mi commented Apr 8, 2024

Hi,

This pull request should close issue 343:
It seems like the snapshot of Spark 4.0.0 changed (again) the signature of AvroDeserializer's c'tor.
I added support for the new c'tor, while changing the code so it won't fail and recover - instead it just looks for a c'tor that is supported and use it.
If it can't find a c'tor - it throws NoSuchMethodException - but with a message that describes what c'tors are supported, so it will be easier to support more c'tors in the future.

@ni-mi ni-mi marked this pull request as ready for review April 8, 2024 19:16
@ni-mi
Copy link
Contributor Author

ni-mi commented Apr 8, 2024

@cerveada / @kevinwallimann I'd appreciate your review on this.

Thanks!

@SlevinBE
Copy link

I was experiencing the same issue as mentioned in #343 (comment)
I've tested this PR with Spark 3.5 on Databricks Runtime 14.3, which contains that new AvroDeserializer, and it solves that issue.
Also, great work on the code improvements and the better error reporting 👍

Copy link
Collaborator

@cerveada cerveada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just read the code

@SlevinBE
Copy link

Since this also impacts those using Spark 3.5 when running on Databricks, it would be great to have a 6.4.1 release for this 🙏

@ni-mi
Copy link
Contributor Author

ni-mi commented Apr 23, 2024

Thanks @SlevinBE and @cerveada 🙏
Can you merge?
AFAIK the CI check JaCoCo code-coverage failure seems to be unrelated - "HttpError: Resource not accessible by integration"

@cerveada
Copy link
Collaborator

AFAIK the CI check JaCoCo code-coverage failure seems to be unrelated - "HttpError: Resource not accessible by integration"

yeah, I am not worried about this.

Let's wait for @kevinwallimann

@ni-mi
Copy link
Contributor Author

ni-mi commented Apr 24, 2024

@kevinwallimann Can you please merge it - so we might be able to release a 6.4.1 release for Databricks?

Thanks!

@kevinwallimann kevinwallimann merged commit 11c2849 into AbsaOSS:master Apr 29, 2024
10 of 11 checks passed
@kevinwallimann
Copy link
Collaborator

kevinwallimann commented Apr 30, 2024

@kevinwallimann Can you please merge it - so we might be able to release a 6.4.1 release for Databricks?

Thanks!

Hi @ni-mi I've merged this PR and have just released a new version 6.4.1 to Maven Central. Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spark 3.4 Support
4 participants