This repository has been archived by the owner on Aug 13, 2021. It is now read-only.
add in security test and fixes plus local dev #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Being able to run the security test locally involved putting all the dependencies in a local /vendor folder, so that's what I did. An alternate approach would be to reference them as absolute URL's from the hacksoc.co.uk domain, for example: <script src="https://hacksoc.co.uk/vendor/jquery/jquery.min.js"></script> ...so can rework this commit to do that if it seems like a better approach.
|
Just to note, I'm sure these PR's seem like they're coming out of nowhere. I'm a web dev recently relocated to Dundee, and came across the Abertay Ethical Hacking Society as a local group that sounded really interesting. Checked out the site and noticed some easy wins for improvement. Hoping to attend the event on Feb 19! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to run the security test locally involved putting all the dependencies
in a local /vender folder, so that's what I did.
An alternate approach would be to reference them as absolute URL's from the
<script src="https://hacksoc.co.uk/vendor/jquery/jquery.min.js"></script>hacksoc.co.uk domain, for example:
...so can rework this commit to do that if it seems like a better approach.