fix unexpected behavior around filters with validators

lib/active_interaction/base.rb

@@ -205,6 +205,7 @@ def run_validations!
  filter
 
  super if errors.empty?
+ errors.empty?
  end
 
  private

lib/active_interaction/modules/validation.rb

@@ -8,10 +8,10 @@ module Validation
  class << self
  # @param context [Base]
  # @param filters [Hash{Symbol => Filter}]
- # @param inputs [Inputs]
- def validate(context, filters, inputs)
+ # @param _inputs [Inputs]
+ def validate(context, filters, _inputs)
  filters.each_with_object([]) do |(name, filter), errors|
- input = filter.process(inputs[name], context)
+ input = filter.process(context.send(name), context)
 
  input.errors.each do |error|
  errors << [error.name, error.type, error.options]

spec/active_interaction/base_spec.rb

@@ -5,6 +5,11 @@
  float :thing
 end
 
+InteractionWithFilterAndValidator = Class.new(TestInteraction) do
+ string :thing
+ validates :thing, presence: true
+end
+
 InteractionWithDateFilter = Class.new(TestInteraction) do
  date :thing
 end
@@ -105,6 +110,19 @@ def execute
  expect(interaction.thing).to eql Date.new(year, month, day)
  end
  end
+
+ context 'and a validator' do
+ let(:described_class) { InteractionWithFilterAndValidator }
+
+ it 'returns false with no value given' do
+ expect(interaction.valid?).to be false
+ end
+
+ it 'returns true when value is given later' do
+ interaction.thing = 'potato'
+ expect(interaction).to be_valid
+ end
+ end
  end
  end
 

spec/active_interaction/modules/validation_spec.rb

@@ -4,7 +4,7 @@
  let(:filter) { ActiveInteraction::Filter.new(:name, {}) }
  let(:interaction) do
  name = filter.name
- klass = Class.new(ActiveInteraction::Base) { attr_writer(name) }
+ klass = Class.new(ActiveInteraction::Base) { attr_accessor(name) }
  klass.filters[name] = filter
  klass.new
  end