Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't mix types in HasValuesAggregator fallback #570

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

HLasse
Copy link
Collaborator

@HLasse HLasse commented May 17, 2024

Since the output of HasValuesAggregator is of type bool, newer versions of polars error when using np.nan as fallback, as np.nan is a float, and polars can't find a suitable type for the Series.

This is a temporary fix that changes the fallback used in the test for HasValuesAggregator to False. Going forward, Ia propose we change the output to 0/1 instead of bools, as 2) they have the same semantic meaning, 1) they have to be transformed to ints anyways before modelling, and 3) it will allow us to still use np.nan as fallback. Added in issue for this in #569

Copy link

codspeed-hq bot commented May 17, 2024

CodSpeed Performance Report

Merging #570 will not alter performance

Comparing fix-failing-tests (6e403d5) with main (3d662f8)

Summary

✅ 7 untouched benchmarks

@HLasse HLasse changed the title fix: don't fix types in HasValuesAggregator fallback fix: don't mix types in HasValuesAggregator fallback May 17, 2024
Copy link
Contributor

This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 21, 2024
@HLasse HLasse merged commit 60d1987 into main May 21, 2024
13 checks passed
@HLasse HLasse deleted the fix-failing-tests branch May 21, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant