fix: don't mix types in HasValuesAggregator fallback #570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the output of
HasValuesAggregator
is of typebool
, newer versions of polars error when usingnp.nan
as fallback, asnp.nan
is a float, and polars can't find a suitable type for the Series.This is a temporary fix that changes the fallback used in the test for
HasValuesAggregator
to False. Going forward, Ia propose we change the output to 0/1 instead of bools, as 2) they have the same semantic meaning, 1) they have to be transformed to ints anyways before modelling, and 3) it will allow us to still use np.nan as fallback. Added in issue for this in #569