fix(#480): pure NaNs when flattening with lookbehind-tuple in 01_basic #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
HLasse
deleted the
fix/480/pure_NaNs_when_flattening_with_lookbehind-tuple_in_01_basic
branch
CodSpeed Performance ReportMerging #489 will not alter performanceComparing Summary
|
| joined_frame = predictiontime_frame.df.join( | ||
| value_frame.df, on=predictiontime_frame.entity_id_col_name, how="left" | ||
| # ensure that the timestamp col names are different to avoid conflicts | ||
| unique_predictiontime_frame_timestamp_col_name = ( |
There was a problem hiding this comment.
I think the terminology here is a bit confusing; it isn't unique, but rather it is different from the one in the value_frame, right?
If that's the case, we might want to guard it to clarify intent. E.g. if predictiontime_frame.timestamp_col_name == value_frame.timestamp_col_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(#480): pure NaNs when flattening with lookbehind-tuple in 01_basic
Fixes #480
fix: bug in
_get_timedelta_frameif timestamp col names were the same