Update Model section of developer guide #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflected new AppointmentBook model, as well as changes to existing Person model.
rxchell
requested changes
Oct 16, 2024
There was a problem hiding this comment.
LGTM.
The diagram appears fine in puml, but the arrows appear different in the docs.
Screenshot of the docs (some arrows are not pointing to their corresponding class)
There was a problem hiding this comment.
This is a weird issue, no idea whats the issue
There was a problem hiding this comment.
For the description if the BetterModelClassDiagram under Note: (line 140), the "Tag list in the AddressBook" can be specified to be UniqueTagList
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #79
Reflected new AppointmentBook model, as well as changes to existing Person model.