Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enhancement for dg #343

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Add enhancement for dg #343

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b9dced
feat: add enhancement for dg
jayjay19630 Nov 12, 2024
f84cff1
feat: add sickness enhancmenet
jayjay19630 Nov 12, 2024
1693e5c
fix: add fullstop
jayjay19630 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions docs/DeveloperGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,6 +1129,17 @@ Team size: 5
* **Sample Input:** User enters `... d/2024-05-12 25:61`
* **Expected Output:** The result display box shows `Invalid time format. Please enter a valid time between 00:00 and 23:59.`

6. **Update patient name in appointment when patient's name is edited**
* **Flaw:** When users edit a `person` with a new name, his/her appointments still refer to the old name.
* **Enhancement:** During the EditPersonCommand, also edit any appointments with this patient to point to the new Person object.
* **Sample Input:** Suppose there is a person indexed 1 named John. Execute `edit person 1 n/Jonathan`.
* **Expected Output:** Any appointments with John should now refer to Jonathan.

7. **You can only add appointments without sickness or medicine, but not edit them**
* **Flaw:** When users edit an `appointment` such that sickness or medicine is null, the GUI invalidates this input even though these fields are optional.
* **Enhancement:** Change input validation for sickness and medicine to allow for null values.
* **Sample Input:** `edit appt 1 s/ m/`
* **Expected Output:** Appointment indexed 1 should have sickness and medicine shown as null.

<br>

Expand Down