Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update Developer Guide #252

Merged

Conversation

rxchell
Copy link

@rxchell rxchell commented Nov 7, 2024

Fixes #142

@rxchell rxchell added this to the v1.5 milestone Nov 7, 2024
@rxchell rxchell self-assigned this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link

@zaidansani zaidansani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - formatting/diagrams

@choiwab
Copy link

choiwab commented Nov 7, 2024

LGTM

Copy link

@jayjay19630 jayjay19630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the design considerations, just some typos that need fixing.

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
* Difficult to cross reference when typing certain commands
* **Alternative 1 (current choice):** Show lists as two separate panels side by side.
* **Pros**: Easier to see all information at once, and easier to cross-reference when doing `add appt`
or `edit appt` commands, which may need information about `personId`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making reference to personId consistent throughout entire DG

Copy link

@jayjay19630 jayjay19630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayjay19630 jayjay19630 merged commit 6b28e66 into AY2425S1-CS2103T-W10-2:master Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update and Review DG
4 participants