Merge pull request #341 from zaidansani/fix-appointment-deletion-by-p…

…ersonId Fix delete person before edit bug
AY2425S1-CS2103T-W10-2 · Nov 11, 2024 · 9c3d19e · 9c3d19e
2 parents 20bb164 + f94da73
commit 9c3d19e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/main/java/seedu/address/model/AppointmentBook.java b/src/main/java/seedu/address/model/AppointmentBook.java
@@ -129,7 +129,6 @@ public Appointment addAppointment(Person person, AppointmentDescriptor appointme
      */
     public void setAppointment(Appointment target, Appointment editedAppointment) {
         requireNonNull(editedAppointment);
-
         appointments.setAppointment(target, editedAppointment);
     }
 

diff --git a/src/main/java/seedu/address/model/appointment/UniqueAppointmentList.java b/src/main/java/seedu/address/model/appointment/UniqueAppointmentList.java
@@ -125,7 +125,7 @@ public void setAppointments(List<Appointment> appointments) {
      */
     public void removeAppointmentsForPerson(Person toRemove) {
         requireNonNull(toRemove);
-        internalList.removeIf(appointment -> appointment.getPerson().equals(toRemove));
+        internalList.removeIf(appointment -> appointment.getPersonId() == toRemove.getPersonId());
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up @@
          */
         public void setAppointment(Appointment target, Appointment editedAppointment) {
             requireNonNull(editedAppointment);
             appointments.setAppointment(target, editedAppointment);
         }
@@ Expand Down @@