-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UG for CS2101 submission #559
base: master
Are you sure you want to change the base?
Changes from all commits
7878500
cb95a30
4ecfe14
eeb3fc5
75105ce
729c7c5
e254679
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,4 @@ show-in: [ug, dg] | |
|
||
The region located at the right half of FoodRem's main window. | ||
|
||
To view more information, refer to the [Layout](/UserGuide.html#layout) section of the User Guide. | ||
To view more information, refer to the [Layout](#layout) section of the User Guide. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,4 @@ show-in: [ug, dg] | |
|
||
A pop-up window containing help information, shown only after calling a `help` command. | ||
|
||
To view more information, refer to the [Layout](/UserGuide.html#layout) section of the User Guide. | ||
To view more information, refer to the [Layout](#layout) section of the User Guide. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup, this needs to be fixed, but this is not the fix. The issue is that if we don't use a fragment, this will break the PDF version of the UG since it will try to open a website instead. Working on a fix in the validation. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,4 @@ show-in: [ug, dg] | |
|
||
The region located at the bottom-left of FoodRem's main window. | ||
|
||
To view more information, refer to the [Layout](/UserGuide.html#layout) section of the User Guide. | ||
To view more information, refer to the [Layout](#layout) section of the User Guide. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup, this needs to be fixed, but this is not the fix. The issue is that if we don't use a fragment, this will break the PDF version of the UG since it will try to open a website instead. Working on a fix in the validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line breaks for the DG, seeing how the pipeline is failing as well. This section is supposed to show in the DG and link to the UG's layout section so just
[Layout](#layout)
doesn't seem to be working for the DG tho it does fix the broken link for UG.Alternatively, since the actual link we want is
https://ay2223s1-cs2103t-w16-2.github.io/tp/UserGuide.html#layout
while the previous link links tohttps://ay2223s1-cs2103t-w16-2.github.io/UserGuide.html#layout
, maybe just adding the missing/tp
like[Layout](/tp/UserGuide.html#layout)
would suffice.