Enhancement/enhanced polyhedral gravity model #825
+426
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the math to evaluate polyhedron gravity to be more computationally efficient. The key is to initialize and store several variables that are non-related to the evaluation point.
Verification
The polyhedron gravBody unit test succeeds.
Documentation
I've included html documentation for the polyhedron gravity. I think that by proceeding this way, the documentation is more clearer and accessible than with the big pdf on gravityEffector. But open to other thoughts.
Future work
Should the gravity models be stored in specific folders within the gravityEffector folder? It'd feel more organized this way.
As my time allows, I'd try to PR other features that could be of interest to BSK project.