Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akp mt updates #383

Open
wants to merge 2 commits into
base: 1.7.0
Choose a base branch
from
Open

Akp mt updates #383

wants to merge 2 commits into from

Conversation

paulsonak
Copy link
Collaborator

Small updates for multitask model evaluation. See #382 for more info.

  1. Update compare_models to check for multiple dataset_keys instead of multiple response_columns
  2. Update MinimalDataset to calculate weights for training data predictions / metrics calculation.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
atomsci/ddm/pipeline/model_datasets.py 33.33% 2 Missing ⚠️
atomsci/ddm/pipeline/compare_models.py 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##            1.7.0     #383      +/-   ##
==========================================
+ Coverage   20.29%   22.84%   +2.54%     
==========================================
  Files          47       47              
  Lines       12883    12885       +2     
==========================================
+ Hits         2615     2943     +328     
+ Misses      10268     9942     -326     
Files with missing lines Coverage Δ
atomsci/ddm/pipeline/compare_models.py 5.64% <0.00%> (ø)
atomsci/ddm/pipeline/model_datasets.py 47.69% <33.33%> (-0.20%) ⬇️

... and 5 files with indirect coverage changes


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant