Fix hardcoded domains #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for twelvecash ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chdwlch
approved these changes
Aug 30, 2024
|
I did find a bug where it did not go to confetti after paying, so I'll fix that in another PR |
sbddesign
added a commit
that referenced
this pull request
Oct 4, 2024
* User Accounts and Paid User Names (#35) * add initial prisma schema * intial prisma, nostr auth, mess * store jwt in httponly cookie, user hook, user ctx in trpc * add logout button and route to expire/delete cookie * add getUserServer from token, fix window bug, setUser on log in * add random paycode trpc endpoint * remove v2 record route * get user paycodes endpoint * display paycodes on account page * add paid paycode flow, need to hook up ln node rest * add qr code * add lnd rest create invoice lookup invoice * limit userName input characters to a-z, 0-9, ., -, _ * move to .env for prisma * add db steps to readme * User Accounts UI (#37) * tidy up login page * nostr login cleanup * account page cleanup * added toggle ui for paid and free * spruced up invoice screen * swapped paid page into new page * simplified command in readme * add the ability to use both paid and free endpoints in the new ui (#38) * add the ability to use both paid and free endpoints in the new ui * centered footer --------- Co-authored-by: Stephen DeLorme <[email protected]> --------- Co-authored-by: Chad Welch <[email protected]> * Mobile Fixes (#42) * mobile hamburger menu * improved home page on mobile * mobile fixes for check page * mobile fixes to account page * mobile fixes to username creation * Fix and test createBip21FromParams function (#43) * fix createBip21 tests to use new parameters * fix and test createBip21FromParams * update pricing (#46) * Fix hardcoded domains (#48) * pull domains from env * added new form to client component * Social metadata (#52) * add metadata for #39 and #40 Co-authored-by: Paulo Sacramento <[email protected]> * overwrite facicon file Co-authored-by: Paulo Sacramento <[email protected]> --------- Co-authored-by: Paulo Sacramento <[email protected]> * temp remove reference to ln addr until conversion is added --------- Co-authored-by: Chad Welch <[email protected]> Co-authored-by: Paulo Sacramento <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #33 and issues with latest staging to master PR. Basically, 12cash.dev was hardcoded in some places. To fix this, I had to move the new paycode form into a client component, determine the appropriate domain to use from within the erver page
/new, and then pass the domain into the client component.This expects to find either 12cash.dev or twelve.cash in the env, meaning on staging or dev you want:
DOMAINS={"12cash.dev": "def456"} #stagingand on prod you want:
DOMAINS={"twelve.cash": "abc123"} #productionIn future, we can add support for pulling other fun domains from the DOMAINS object and have a way to specify which is the default in the list.