Skip to content

Commit

Permalink
WS2 2.9.0 release final CSS compilation + README.md update
Browse files Browse the repository at this point in the history
  • Loading branch information
mlsamuelson committed Mar 18, 2023
1 parent 24dff7c commit f8b3240
Show file tree
Hide file tree
Showing 6 changed files with 7,502 additions and 7,325 deletions.
12 changes: 11 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,17 @@ You can roughly connect the stories in the `*.templates.stories.js` file with th
9. Verify that **ALL** pending pull requests for the release have been merged.
10. Pull all the latest changes into your branch from the main branch with `git pull origin main`.
11. Fix any conficts, if necessary, and commit your changes.
12. When you feel that the release is ready, the final step is to compile and push the CSS. Do this by running `yarn production` again. This time, make sure that you add the changed files in the `assets` directory with `git add` and then commit the changes.
12. When the release is ready, the final step is to compile the CSS for production before your last commit. Do this by running `yarn production` again. This time, make sure that you add the changed files in the `assets` directory with `git add` and then commit the changes. If you get the following error while compiling the scss
```
Module build failed (from ./node_modules/postcss-loader/src/index.js):
JisonLexerError: Lexical error on line 1: Unrecognized text./
[...and then a reference to some scss variables here...]
```
find the offending variables in the `node_modules` code. These variables are probably used inside of a `calc()` function. To resolve for the Renovation compilation script, wrap the variables in `#{}`. For example this
`max-height: calc($uds-card-height - $uds-size-spacing-8);`
should become
`max-height: calc(#{$uds-card-height} - #{$uds-size-spacing-8});`
(Note: this may be able to be resolved with changes on the UDS side, but because at the time of this writing we are embarking on updating to Bootstrap 5, these may change, and the issue can be revisited if it still is an issue after the update.)
13. Push the commit to the remote repository.
14. When your pull request has been approved, merge it into the main branch.
15. Create a new tag for the release (using semantic versioning principles), and update the composer.json file in `webspark-release-testing/upstream-configuration/` with that tag for `"asuwebplatforms/webspark-theme-renovation"`.
Expand Down
2 changes: 1 addition & 1 deletion assets/css/renovation.style.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion assets/js/renovation.script.js

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions assets/js/renovation.script.js.LICENSE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,28 +5,28 @@
*/

/*!
* Sizzle CSS Selector Engine v2.3.5
* Sizzle CSS Selector Engine v2.3.9
* https://sizzlejs.com/
*
* Copyright JS Foundation and other contributors
* Released under the MIT license
* https://js.foundation/
*
* Date: 2020-03-14
* Date: 2022-12-19
*/

/*!
* jQuery JavaScript Library v3.5.1
* jQuery JavaScript Library v3.6.3
* https://jquery.com/
*
* Includes Sizzle.js
* https://sizzlejs.com/
*
* Copyright JS Foundation and other contributors
* Copyright OpenJS Foundation and other contributors
* Released under the MIT license
* https://jquery.org/license
*
* Date: 2020-05-04T22:49Z
* Date: 2022-12-20T21:28Z
*/

/**!
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit f8b3240

Please sign in to comment.