Improvements #21
Open
Improvements #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback signature was changed to pass MQTTPublishInfo_t, which contains the previously passed data. Added a mutex to protect the API against concurrent access. Added a semaphore to check for publish QoS. Added missing QoS parameter to unsubscribe. It is now possible to call processResponses with a single loop.
Do not subscribe to get/rejected topic Do not subscribe to update response topics Improve shadow robustness by calling processResponses until all responses are received
Each subscription now has its own callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was finally able to fork back from the official Mbed repo. I thought it would be a better cooperation opportunity than separately developing in the original repo.
I made many improvements, some of which break the API. The details are found in the commits. I'm not rushing to merge these as I am using my fork permanently, nevertheless feel free to review and comment.