fix: React Router V7 not working with lazy route elements #322
+104
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreaCuneo
requested review from
sean-sligo,
AndreaLandiArk and
a team
as code owners
AndreaCuneo
force-pushed
the
bugfix/router_fails_on_lazy
branch
2 times, most recently
from
365e25e to
aa03aa7
Compare
Mirko92
reviewed
Jan 15, 2025
AndreaCuneo
force-pushed
the
bugfix/router_fails_on_lazy
branch
from
aa03aa7 to
e4f9a84
Compare
Mirko92
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on remix-run/react-router#12474, port to:
Using the React Router 'lazy' property works too, but introduce another bug: doesn't support displaying a Fallback component while waiting for a page to load. Routing remains on the old 'route' until the lazy resolve.