Skip to content
This repository has been archived by the owner on Jul 16, 2020. It is now read-only.

Fix: transform 'oneOf' property to object #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tehcyx
Copy link
Contributor

@tehcyx tehcyx commented Nov 11, 2016

Hi,

We, a team from SAP working on API Hub and YaaS, started using this converter to convert our RAML definitions into Swagger. We found that some of our RAML files were failing to convert so we had to make some changes, and we wanted to share these changes with you. We collected the list of changes we made in this CHANGELOG and will provide each fix as a different pull request for you so that you can pick the ones that you want to support.

The issue to fix
'oneOf' property is not supported by Swagger 2.0

The fix
Resolve 'oneOf' to an object in resulting Swagger spec.

Best regards,
Daniel Roth - SAP Hybris

@IvanGoncharov
Copy link
Member

@tehcyx I'm not sure about this one 😕
By deleting oneOf you loosing a lot of info, how about converting it to x-oneOf so it's still present in spec?

@tehcyx
Copy link
Contributor Author

tehcyx commented Nov 14, 2016

@IvanGoncharov that would be an option. For our use-case, the info was not necessary in the end. Feel free to extend here as well.

@IvanGoncharov
Copy link
Member

@tehcyx Sorry for the delay. But I don't like how convertSchema starting to looks like.
So I want to simplify jsonpath usage, here is PR: dchester/jsonpath#45
Do you have any deadlines for which this PR should be merged?
And can you wait for my PR to be merged before I merge yours?

@tehcyx
Copy link
Contributor Author

tehcyx commented Nov 29, 2016

Hey @IvanGoncharov no problem. No deadlines. We're did use our modified version for the conversion and going forward we'll the use the patched one once it's in the master branch. You have all the time you need.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants